[llvm-commits] [llvm] r92995 - /llvm/trunk/lib/Target/X86/X86FastISel.cpp

Eric Christopher echristo at apple.com
Fri Jan 8 00:24:50 PST 2010


Author: echristo
Date: Fri Jan  8 02:24:49 2010
New Revision: 92995

URL: http://llvm.org/viewvc/llvm-project?rev=92995&view=rev
Log:
After further thought revert the patch to make fast-isel avoid
putting relocations into the constant pool - this isn't needed
for correctness and in the rare occasion it happens would pull
us out of fast isel for the block.

If fast-isel application startup time ever becomes an issue we
can add better support for these addresses instead of bailing.

Modified:
    llvm/trunk/lib/Target/X86/X86FastISel.cpp

Modified: llvm/trunk/lib/Target/X86/X86FastISel.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FastISel.cpp?rev=92995&r1=92994&r2=92995&view=diff

==============================================================================
--- llvm/trunk/lib/Target/X86/X86FastISel.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86FastISel.cpp Fri Jan  8 02:24:49 2010
@@ -1652,12 +1652,6 @@
     PICBase = X86::RIP;
   }
 
-  // If we've gotten here we need to make sure we don't have a constant
-  // that needs a relocation, because then we shouldn't put it into the
-  // constant pool.
-  if (C->getRelocationInfo() != Constant::NoRelocation)
-    return 0;
-  
   // Create the load from the constant pool.
   unsigned MCPOffset = MCP.getConstantPoolIndex(C, Align);
   unsigned ResultReg = createResultReg(RC);





More information about the llvm-commits mailing list