[llvm-commits] [llvm] r92455 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/X86/x86-64-jumps.ll

Chris Lattner sabre at nondot.org
Sun Jan 3 10:33:18 PST 2010


Author: lattner
Date: Sun Jan  3 12:33:18 2010
New Revision: 92455

URL: http://llvm.org/viewvc/llvm-project?rev=92455&view=rev
Log:
fix PR5930, allowing the asmprinter to emit difference between
two labels as a truncate.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    llvm/trunk/test/CodeGen/X86/x86-64-jumps.ll

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=92455&r1=92454&r2=92455&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Sun Jan  3 12:33:18 2010
@@ -819,7 +819,6 @@
     const TargetData *TD = TM.getTargetData();
     unsigned Opcode = CE->getOpcode();    
     switch (Opcode) {
-    case Instruction::Trunc:
     case Instruction::ZExt:
     case Instruction::SExt:
     case Instruction::FPTrunc:
@@ -865,7 +864,6 @@
       return EmitConstantValueOnly(Op);
     }
       
-      
     case Instruction::PtrToInt: {
       // Support only foldable casts to/from pointers that can be eliminated by
       // changing the pointer to the appropriately sized integer type.
@@ -887,6 +885,14 @@
       O << ") & " << S.str() << ')';
       break;
     }
+        
+    case Instruction::Trunc:
+      // We emit the value and depend on the assembler to truncate the generated
+      // expression properly.  This is important for differences between
+      // blockaddress labels.  Since the two labels are in the same function, it
+      // is reasonable to treat their delta as a 32-bit value.
+      return EmitConstantValueOnly(CE->getOperand(0));
+        
     case Instruction::Add:
     case Instruction::Sub:
     case Instruction::And:

Modified: llvm/trunk/test/CodeGen/X86/x86-64-jumps.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/x86-64-jumps.ll?rev=92455&r1=92454&r2=92455&view=diff

==============================================================================
--- llvm/trunk/test/CodeGen/X86/x86-64-jumps.ll (original)
+++ llvm/trunk/test/CodeGen/X86/x86-64-jumps.ll Sun Jan  3 12:33:18 2010
@@ -14,3 +14,32 @@
   ret i8 2
 }
 
+
+; PR5930 - Trunc of block address differences.
+ at test.array = internal constant [3 x i32] [i32 trunc (i64 sub (i64 ptrtoint (i8* blockaddress(@test2, %foo) to i64), i64 ptrtoint (i8* blockaddress(@test2, %foo) to i64)) to i32), i32 trunc (i64 sub (i64 ptrtoint (i8* blockaddress(@test2, %bar) to i64), i64 ptrtoint (i8* blockaddress(@test2, %foo) to i64)) to i32), i32 trunc (i64 sub (i64 ptrtoint (i8* blockaddress(@test2, %hack) to i64), i64 ptrtoint (i8* blockaddress(@test2, %foo) to i64)) to i32)] ; <[3 x i32]*> [#uses=1]
+
+define void @test2(i32 %i) nounwind ssp {
+entry:
+  %i.addr = alloca i32                            ; <i32*> [#uses=2]
+  store i32 %i, i32* %i.addr
+  %tmp = load i32* %i.addr                        ; <i32> [#uses=1]
+  %idxprom = sext i32 %tmp to i64                 ; <i64> [#uses=1]
+  %arrayidx = getelementptr inbounds i32* getelementptr inbounds ([3 x i32]* @test.array, i32 0, i32 0), i64 %idxprom ; <i32*> [#uses=1]
+  %tmp1 = load i32* %arrayidx                     ; <i32> [#uses=1]
+  %idx.ext = sext i32 %tmp1 to i64                ; <i64> [#uses=1]
+  %add.ptr = getelementptr i8* blockaddress(@test2, %foo), i64 %idx.ext ; <i8*> [#uses=1]
+  br label %indirectgoto
+
+foo:                                              ; preds = %indirectgoto, %indirectgoto, %indirectgoto, %indirectgoto, %indirectgoto
+  br label %bar
+
+bar:                                              ; preds = %foo, %indirectgoto
+  br label %hack
+
+hack:                                             ; preds = %bar, %indirectgoto
+  ret void
+
+indirectgoto:                                     ; preds = %entry
+  %indirect.goto.dest = phi i8* [ %add.ptr, %entry ] ; <i8*> [#uses=1]
+  indirectbr i8* %indirect.goto.dest, [label %foo, label %foo, label %bar, label %foo, label %hack, label %foo, label %foo]
+}





More information about the llvm-commits mailing list