[llvm-commits] [llvm] r91842 - /llvm/trunk/include/llvm/Support/Format.h

Anton Korobeynikov asl at math.spbu.ru
Tue Dec 22 01:34:22 PST 2009


Hello, Daniel

> This broke the MSVC build, please take a look.
I don't have vcpp around, but this patch unbreaks a mingw build (which
was broken for quite long time). I explained, why it is incorrect
regardless of compiler.

I'd really appreciate if someone with vcpp access look into this issue.
Maybe we should do a #ifdef _MSC_VER, but this is still a hackish way to
do things :(

Note, that the most notable difference of snprintf and _snprintf is that
the latter *does not* guarantee NULL termination!

--
WBR, Anton Korobeynikov 



More information about the llvm-commits mailing list