[llvm-commits] [llvm] r91552 - /llvm/trunk/utils/unittest/googletest/gtest.cc

Chandler Carruth chandlerc at google.com
Fri Dec 18 00:31:05 PST 2009


On Wed, Dec 16, 2009 at 3:59 PM, Bill Wendling <isanbard at gmail.com> wrote:
> On Dec 16, 2009, at 3:27 PM, Eli Friedman wrote:
>> On Wed, Dec 16, 2009 at 11:36 AM, Bill Wendling <isanbard at gmail.com> wrote:
>>> Author: void
>>> Date: Wed Dec 16 13:36:42 2009
>>> New Revision: 91552
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=91552&view=rev
>>> Log:
>>> Remove superfluous 'extern' variable that was causing a warning with clang.
>>>
>>> Modified:
>>>    llvm/trunk/utils/unittest/googletest/gtest.cc
>>
>> Do we care whether fixes are sent upstream for googletest?
>>
> If they don't mind taking the patch, then sure.

It has already been fixed upstream IIRC. We're parsing gtest and gmock
with Clang regularly.

>
> -bw
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list