[llvm-commits] [llvm] r91489 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp lib/Target/X86/X86Instr64bit.td lib/Target/X86/X86InstrInfo.td test/CodeGen/X86/setcc.ll

[Török Edwin]

On 2009-12-16 12:38, Török Edwin wrote:
> On 2009-12-16 02:53, Evan Cheng wrote:
>   
>> Author: evancheng
>> Date: Tue Dec 15 18:53:11 2009
>> New Revision: 91489
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=91489&view=rev
>> Log:
>> Re-enable 91381 with fixes.
>>
>> Modified:
>>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>>     llvm/trunk/lib/Target/X86/X86Instr64bit.td
>>     llvm/trunk/lib/Target/X86/X86InstrInfo.td
>>     llvm/trunk/test/CodeGen/X86/setcc.ll
>>
>> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=91489&r1=91488&r2=91489&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
>> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Dec 15 18:53:11 2009
>> @@ -980,6 +980,7 @@
>>    setTargetDAGCombine(ISD::SRL);
>>    setTargetDAGCombine(ISD::STORE);
>>    setTargetDAGCombine(ISD::MEMBARRIER);
>> +  setTargetDAGCombine(ISD::ZERO_EXTEND);
>>   
>>     
>
> Hi Evan,
>
> I noticed an infloop convertin and->zero_extend->and, could this patch
> be the cause?
> http://llvm.org/bugs/show_bug.cgi?id=5802
>   

git bisect tells me that SVN r91380 introduces the infloops:

5b6187226b44f590ce7f614b128480b9c2d823ef is the first bad commit
commit 5b6187226b44f590ce7f614b128480b9c2d823ef
Author: Evan Cheng <evan.cheng at apple.com>
Date:   Tue Dec 15 00:52:11 2009 +0000

    Fold (zext (and x, cst)) -> (and (zext x), cst).


    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@91380
91177308-0d34-0410-b5e6-96231b3b80d8

Best regards,
--Edwin