[llvm-commits] [llvm] r90644 - /llvm/trunk/docs/LangRef.html

Chris Lattner clattner at apple.com
Fri Dec 4 21:23:29 PST 2009


On Dec 4, 2009, at 6:46 PM, Eric Christopher wrote:

> Author: echristo
> Date: Fri Dec  4 20:46:03 2009
> New Revision: 90644
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=90644&view=rev
> Log:
> More updates to objectsize intrinsic docs.

*grumble* trailing whitespace :)

Some more requests:

1) As we discussed on IRC, llvm doesn't have a useful notion of a partial object, please change the 'type' argument to an i1.  Also, in the Arguments section point out that the type needs to be a literal 0 or 1, variables are not allowed.  Please update the implementation to match of course.

2) "An object in this context means an allocation of a specific type".  The type doesn't really have anything to do with it, please explain the possible things an 'object' could be.

3) "The first argument is a pointer to the object ptr."  it may be a pointer "into" an object as well.  Please don't contract 'ptr'.

Thanks Eric,

-Chris







More information about the llvm-commits mailing list