[llvm-commits] Change indirect-globals to use a dedicated allocIndirectGV (issue157145)

jyasskin at gmail.com jyasskin at gmail.com
Tue Nov 24 11:28:10 PST 2009


Reviewers: evan.cheng_apple.com,

Message:
Hi Evan, could you take a look?
http://codereview.appspot.com/download/issue157145_7.diff
I think this is an ok change for arm (and it passes tests on nlewycky's
box) because even though the indirect global is generated as part of a
call stub, it's not actually executed.

Description:
This lets us remove start/finishGVStub and the BufferState helper class
from the MachineCodeEmitter interface.  It has the side-effect of not
setting the indirect global writable and then executable on ARM, but
that shouldn't be necessary.

Please review this at http://codereview.appspot.com/157145

Affected files:
   M     include/llvm/CodeGen/JITCodeEmitter.h
   M     include/llvm/CodeGen/MachineCodeEmitter.h
   M     lib/ExecutionEngine/JIT/JITEmitter.cpp
   M     lib/Target/ARM/ARMJITInfo.cpp
   M     lib/Target/Alpha/AlphaJITInfo.cpp
   M     lib/Target/PowerPC/PPCJITInfo.cpp
   M     lib/Target/X86/X86JITInfo.cpp





More information about the llvm-commits mailing list