[llvm-commits] [llvm] r89765 - in /llvm/trunk: include/llvm/System/Path.h lib/System/Unix/Path.inc lib/System/Win32/Path.inc

[Daniel Dunbar]

On Tue, Nov 24, 2009 at 8:34 AM, Edward O'Callaghan
<eocallaghan at auroraux.org> wrote:
> G'Day Duncan,
>
> 2009/11/24 Duncan Sands <baldrick at free.fr>:
>> Hi,
>>
>>> +      /// This function checks that what we're trying to work only on a
>>> regular file or Dir.
>>
>> Dir -> directory
>>
>>> +      /// Check for things like /dev/null, any block special file,
>>> +      /// or other things that aren't "regular" files.
>>
>> files -> regular files or directories
>>
>
> Fix committed in revision 89770, Cheers!
>
>>> +bool
>>> +Path::isSpecialFile() const {
>>> +  return false;
>>> +}
>>
>> Windows does have special files AFAIK, for example opening "nul"
>> gives the effect of /dev/null on unix systems.
>
> OK, then I don't know the details of this nor do I have a windows
> machine to expand on this hook.
> Are you able to provide some more detail, is this bug a problem on
> windows as well?

Don't worry about it, if someone on Windows cares we can fix it then.

  - Daniel

>>
>> Ciao,
>>
>> Duncan.
>>
>
> Many thanks for your review,
> Edward.
>
>
> --
> --
> Edward O'Callaghan
> http://www.auroraux.org/
> eocallaghan at auroraux dot org
> ---
> ()  ascii ribbon campaign - against html e-mail
> /\                        - against microsoft attachments
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>