[llvm-commits] [PATCH] More Spill Annotations

[Evan Cheng]

On Nov 23, 2009, at 12:11 PM, David Greene wrote:

> On Monday 23 November 2009 13:39, Evan Cheng wrote:
>> David, this really is not a good idea. You are adding more target hooks
>> purely for asm printing comments. These hooks return instruction properties
>> that should be static so they should be moved to td files.
> 
> Ok, that's reasonable.  There are a number of target hooks that should
> be processed by tblgen, then.  For example, isMoveInstr, GetCondBranchFromCond
> and sizeOfImm.
> 
> To do isVectorInstr and isVectorOperandInstr will require some additional
> flags in the .td files, I think.  Is that ok?  I don't want to to a whole
> bunch of work to find out later that there's a better way.

What kind of flags? These are fairly target specific information so I don't think we want to add anything target independent. Can you enhance asm printer so targets can inject target specific comments?

Evan

> 
>                             -Dave