[llvm-commits] [llvm] r89403 - /llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp

Chris Lattner clattner at apple.com
Mon Nov 23 10:23:46 PST 2009


On Nov 23, 2009, at 10:14 AM, Jim Grosbach wrote:

>>> 
>>> This patch adjusts those padding calculations to know that in the presence of inline assembly, we're dealing with an estimate and therefore can't make assumptions about alignment padding.
>> 
>> Ah ok, so this just causes extra .align directives to be emitted, it doesn't make wildly conservative assumptions?  If so, sounds great! :)
> 
> Close. We're not inserting any additional directives, but rather better understanding the ones we're already emitting. It causes us to correctly understand that when we have inline asm, we don't know for sure when an .align directive will cause padding to be inserted. We know when it may be inserted, and track that instead. Note that in the absence of inline asm, we continue to calculate precisely. I believe this is well on the side of prudently rather than wildly conservative.

Ok, thanks Jim!

-Chris



More information about the llvm-commits mailing list