[llvm-commits] [llvm] r89487 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[Chris Lattner]

On Nov 23, 2009, at 9:56 AM, Devang Patel wrote:
> On Nov 21, 2009, at 7:18 AM, Chris Lattner wrote:
> On Nov 20, 2009, at 1:05 PM, Devang Patel wrote:
>> 
>>> Author: dpatel
>>> Date: Fri Nov 20 15:05:37 2009
>>> New Revision: 89487
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=89487&view=rev
>>> Log:
>>> There is no need to emit source location info for DW_TAG_pointer_type.
>> 
>> This seems like a strange special case.  Why are pointers special here?
> 
> Usually, one pointer type is used many places and FEs do not preserve separate locations for each instance. GCC does not emit location info here. If we get precise location  info from FE then it makes sense to include location info here.

Clang preserves this information and could emit it.  However, this is not really relevant here: shouldn't the decision be left up to the front-end, not discarded arbitrarily by the code generator?  It seems like the right fix is in llvm-gcc, not the llvm backend.

-Chris