[llvm-commits] [llvm] r89602 - /llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp

[Chris Lattner]

Author: lattner
Date: Sun Nov 22 10:16:48 2009
New Revision: 89602

URL: http://llvm.org/viewvc/llvm-project?rev=89602&view=rev
Log:
add fixme for dubious code.  Duncan, what do you think?

Modified:
    llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp

Modified: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp?rev=89602&r1=89601&r2=89602&view=diff

==============================================================================
--- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp (original)
+++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Sun Nov 22 10:16:48 2009
@@ -263,6 +263,7 @@
 bool BasicAliasAnalysis::pointsToConstantMemory(const Value *P) {
   if (const GlobalVariable *GV = 
         dyn_cast<GlobalVariable>(P->getUnderlyingObject()))
+    // FIXME: shouldn't this require GV to be "ODR"?
     return GV->isConstant();
   return false;
 }