[llvm-commits] [llvm] r88874 - in /llvm/trunk: lib/Target/ARM/ARM.h lib/Target/ARM/ARMBaseInstrInfo.cpp lib/Target/ARM/ARMBaseRegisterInfo.cpp lib/Target/ARM/ARMTargetMachine.cpp test/CodeGen/ARM/spill-q.ll test/CodeGen/Thumb2/thumb2-spill-q.ll

[Chris Lattner]

On Nov 16, 2009, at 12:44 PM, Jim Grosbach wrote:

>> 
>> Hi Jim,
>> 
>> Please name the pass something less contracted (so it shows up in doxygen better without context etc). Also, does it need to be an ARM specific pass?  Do other targets have this sort of issue?
>> 
> 
> X86 has the same issue and already has equivalent code. I don't see any reason why the code can't be refactored to be shared between the two and available for other targets. I'll have a look at that.
> 
> As for the name, perhaps something like, "ARM Stack Required Alignment Auto-Detector"? (Removing the "ARM" once it's factored out to not be in the ARM back-end).

Sounds great to me, thanks!

-Chris