[llvm-commits] [llvm] r89487 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Chris Lattner clattner at apple.com
Sat Nov 21 07:18:11 PST 2009


On Nov 20, 2009, at 1:05 PM, Devang Patel wrote:

> Author: dpatel
> Date: Fri Nov 20 15:05:37 2009
> New Revision: 89487
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=89487&view=rev
> Log:
> There is no need to emit source location info for DW_TAG_pointer_type.

This seems like a strange special case.  Why are pointers special here?

-Chris

> 
> Modified:
>    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=89487&r1=89486&r2=89487&view=diff
> 
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Fri Nov 20 15:05:37 2009
> @@ -929,7 +929,7 @@
>     AddUInt(&Buffer, dwarf::DW_AT_byte_size, 0, Size);
> 
>   // Add source line info if available and TyDesc is not a forward declaration.
> -  if (!DTy.isForwardDecl())
> +  if (!DTy.isForwardDecl() && Tag != dwarf::DW_TAG_pointer_type)
>     AddSourceLine(&Buffer, &DTy);
> }
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list