[llvm-commits] [llvm] r89357 - /llvm/trunk/unittests/ADT/StringRefTest.cpp

Benjamin Kramer benny.kra at googlemail.com
Thu Nov 19 08:04:42 PST 2009


Author: d0k
Date: Thu Nov 19 10:04:41 2009
New Revision: 89357

URL: http://llvm.org/viewvc/llvm-project?rev=89357&view=rev
Log:
Reenable Split2 StringRef test with Apple gcc.

Modified:
    llvm/trunk/unittests/ADT/StringRefTest.cpp

Modified: llvm/trunk/unittests/ADT/StringRefTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/StringRefTest.cpp?rev=89357&r1=89356&r2=89357&view=diff

==============================================================================
--- llvm/trunk/unittests/ADT/StringRefTest.cpp (original)
+++ llvm/trunk/unittests/ADT/StringRefTest.cpp Thu Nov 19 10:04:41 2009
@@ -111,11 +111,6 @@
             Str.rsplit('o'));
 }
 
-// XFAIL for PR5482, StringRef is miscompiled by Apple gcc.
-#if (!defined(__llvm__) && defined(__APPLE__) && defined(__OPTIMIZE__))
-#define SKIP_SPLIT2
-#endif
-#ifndef SKIP_SPLIT2
 TEST(StringRefTest, Split2) {
   SmallVector<StringRef, 5> parts;
   SmallVector<StringRef, 5> expected;
@@ -195,7 +190,6 @@
   StringRef("a,,b,c").split(parts, ",", 3, false);
   EXPECT_TRUE(parts == expected);
 }
-#endif
 
 TEST(StringRefTest, StartsWith) {
   StringRef Str("hello");





More information about the llvm-commits mailing list