[llvm-commits] [PATCH] LTO code generator options

[Rafael Espindola]

> This patch adds two SubtargetFeatures::AddFeatures methods which accept a
> comma-separated string or already parsed command line parameters as input,
> SubtargetFeatures::hasFeature method which cheks if given feature is already
> set, and some code re-factoring to use these new methods.

Can you give the StringRef::split method a try?

You say features are normalized, why does hasFeature needs to convert
to lowercase and strip flags?

The comment about "after all explicit feature settings" is a future
reference, right? I don't see any feature being set :-)

The method SubtargetFeatures::AddFeatures(const cl::list<std::string>
&List) is not being used, is it?

> Best regards,
> Viktor

Cheers,
-- 
Rafael Ávila de Espíndola