[llvm-commits] [llvm] r89077 - /llvm/trunk/unittests/ADT/StringRefTest.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Tue Nov 17 03:29:59 2009
New Revision: 89077

URL: http://llvm.org/viewvc/llvm-project?rev=89077&view=rev
Log:
"XFAIL" the Split2 StringReft test with Apple gcc, which miscompiles it.
 - I plan on fixing/workarounding this, but until then I'd like the bots to stay
   green.

Modified:
    llvm/trunk/unittests/ADT/StringRefTest.cpp

Modified: llvm/trunk/unittests/ADT/StringRefTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/StringRefTest.cpp?rev=89077&r1=89076&r2=89077&view=diff

==============================================================================
--- llvm/trunk/unittests/ADT/StringRefTest.cpp (original)
+++ llvm/trunk/unittests/ADT/StringRefTest.cpp Tue Nov 17 03:29:59 2009
@@ -111,6 +111,11 @@
             Str.rsplit('o'));
 }
 
+// XFAIL for PR5482, StringRef is miscompiled by Apple gcc.
+#if (!defined(__llvm__) && defined(__APPLE__) && defined(__OPTIMIZE__))
+#define SKIP_SPLIT2
+#endif
+#ifndef SKIP_SPLIT2
 TEST(StringRefTest, Split2) {
   SmallVector<StringRef, 5> parts;
   SmallVector<StringRef, 5> expected;
@@ -190,6 +195,7 @@
   StringRef("a,,b,c").split(parts, ",", 3, false);
   EXPECT_TRUE(parts == expected);
 }
+#endif
 
 TEST(StringRefTest, StartsWith) {
   StringRef Str("hello");