[llvm-commits] [llvm] r88939 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[Nick Lewycky]

Devang Patel wrote:
> Author: dpatel
> Date: Mon Nov 16 13:20:48 2009
> New Revision: 88939
>
> URL: http://llvm.org/viewvc/llvm-project?rev=88939&view=rev
> Log:
> Add VISIBILITY_HIDDEN marker.

No. Do not do this.

Are these classes supposed to be public or not? If they're not public 
they need to be in an anonymous namespace, and VISIBILITY_HIDDEN 
removed. If they are public, they shouldn't be hidden at all.

The policy in LLVM is that no .cpp file should have VISIBILITY_HIDDEN 
symbols. I am going to revert this patch.

Nick

> Modified:
>      llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=88939&r1=88938&r2=88939&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Mon Nov 16 13:20:48 2009
> @@ -124,7 +124,7 @@
>   //===----------------------------------------------------------------------===//
>   /// DbgVariable - This class is used to track local variable information.
>   ///
> -class DbgVariable {
> +class VISIBILITY_HIDDEN DbgVariable {
>     DIVariable Var;                    // Variable Descriptor.
>     unsigned FrameIndex;               // Variable frame index.
>     DbgVariable *AbstractVar;          // Abstract variable for this variable.
> @@ -146,7 +146,7 @@
>   /// DbgScope - This class is used to track scope information.
>   ///
>   class DbgConcreteScope;
> -class DbgScope {
> +class VISIBILITY_HIDDEN DbgScope {
>     DbgScope *Parent;                   // Parent to this scope.
>     DIDescriptor Desc;                  // Debug info descriptor for scope.
>     WeakVH InlinedAtLocation;           // Location at which scope is inlined.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>