[llvm-commits] [PATCH] Make X86-64 in the Large model always emit 64-bit calls

Dan Gohman gohman at apple.com
Sun Nov 15 07:35:35 PST 2009


On Nov 12, 2009, at 2:35 PM, Jeffrey Yasskin <jyasskin at google.com>  
wrote:

> On Thu, Nov 12, 2009 at 11:46 AM, Dan Gohman <gohman at apple.com> wrote:
>> In the X86ISelLowering.cpp part, disabling the special handling
>> for GlobalAddresses and ExternalSymbols is fine, but the way the
>> proposed patch does that also happens to disable the
>> "else if (isTailCall)" code immediately below that, which handles
>> indirect tail calls. That code is still needed in the large code
>> model -- the callee needs to be in a specific physical register
>> so that it can survive the epilogue.
>
> Oh, right. New version of the patch at
> http://codereview.appspot.com/154066 /
> http://codereview.appspot.com/download/issue154066_23.diff

The X86ISelLowering change looks good.

Dan




More information about the llvm-commits mailing list