[llvm-commits] [llvm] r87047 - in /llvm/trunk: include/llvm/Target/TargetInstrInfo.h lib/Target/X86/X86InstrInfo.cpp lib/Target/X86/X86InstrInfo.h

Chris Lattner clattner at apple.com
Thu Nov 12 17:36:05 PST 2009


On Nov 12, 2009, at 4:29 PM, David Greene wrote:

> Author: greened
> Date: Thu Nov 12 18:29:53 2009
> New Revision: 87047
>
> URL: http://llvm.org/viewvc/llvm-project?rev=87047&view=rev
> Log:
>
> Fix a bootstrap failure.
>
> Provide special isLoadFromStackSlotPostFE and isStoreToStackSlotPostFE
> interfaces to explicitly request checking for post-frame ptr  
> elimination
> operands.  This uses a heuristic so it isn't reliable for correctness.

Hi David,

Aside from Bill's rage :), I really don't think that this is the right  
approach.  The code generator should already have this information  
from MemOperands and we generally prefer to have fewer (not more)  
random target hooks.  I really don't like having to implement two  
different target hooks that are slightly different.

-Chris




More information about the llvm-commits mailing list