[llvm-commits] [llvm-gcc-4.2] r86892 - /llvm-gcc-4.2/trunk/gcc/llvm-abi.h

[Dale Johannesen]

On Nov 12, 2009, at 5:14 PMPST, Bob Wilson wrote:
>>
>> Also, can't this result in reading bytes off the end of the  
>> struct?  That isn't safe if the load crosses a page boundary.
>
> You may very well be right.  I was following the precedent of the  
> x86-64 code, which has this comment:
>
> /// .... This means we'll be loading bytes off the end of the object
> /// in some cases.  That's what gcc does, so it must be OK, right?   
> Right?
>
> (before the llvm_x86_should_pass_aggregate_in_integer_regs function).

Ah, well, I wrote that comment, so feel free to do it right:)