[llvm-commits] [llvm] r87030 - /llvm/trunk/lib/CodeGen/VirtRegRewriter.cpp

[Daniel Dunbar]

It looks like things are coming back to happy. I made a test fix in
r87049 that I don't really understand why it changed, but it seems
fine.

 - Daniel

On Thu, Nov 12, 2009 at 4:30 PM, Bill Wendling <wendling at apple.com> wrote:
> I'm in the process of doing a revert now. I'm just going to revert the
> patches that David committed during that time:
>
> for i in -87034 -87030 -87029 -87028 -87027 -87026 -87025 -87022 ; do
> echo $ svn merge -c $i https://llvm.org/svn/llvm-project/llvm/trunk
> svn merge -c $i https://llvm.org/svn/llvm-project/llvm/trunk
> done
>
> -bw
>
> On Nov 12, 2009, at 4:26 PM, Daniel Dunbar wrote:
>
>> Hi David,
>>
>> I think something in this commit sequence broke things, the buildbots
>> are failing everywhere. I'm going to revert-crazy as soon as I figure
>> out what to revert unless you beat me to it with a fix. :)
>>
>> - Daniel
>>
>> On Thu, Nov 12, 2009 at 1:07 PM, David Greene <greened at obbligato.org>
>> wrote:
>>>
>>> Author: greened
>>> Date: Thu Nov 12 15:07:54 2009
>>> New Revision: 87030
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=87030&view=rev
>>> Log:
>>>
>>> Set the ReloadReuse AsmPrinter flag where appropriate.
>>>
>>> Modified:
>>>   llvm/trunk/lib/CodeGen/VirtRegRewriter.cpp
>>>
>>> Modified: llvm/trunk/lib/CodeGen/VirtRegRewriter.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/VirtRegRewriter.cpp?rev=87030&r1=87029&r2=87030&view=diff
>>>
>>>
>>> ==============================================================================
>>> --- llvm/trunk/lib/CodeGen/VirtRegRewriter.cpp (original)
>>> +++ llvm/trunk/lib/CodeGen/VirtRegRewriter.cpp Thu Nov 12 15:07:54 2009
>>> @@ -1704,6 +1704,7 @@
>>>
>>>            // Mark is killed.
>>>            MachineInstr *CopyMI = prior(InsertLoc);
>>> +            CopyMI->setAsmPrinterFlag(AsmPrinter::ReloadReuse);
>>>            MachineOperand *KillOpnd =
>>> CopyMI->findRegisterUseOperand(InReg);
>>>            KillOpnd->setIsKill();
>>>            UpdateKills(*CopyMI, TRI, RegKills, KillOps);
>>> @@ -1984,6 +1985,7 @@
>>>          TII->copyRegToReg(MBB, InsertLoc, DesignatedReg, PhysReg, RC,
>>> RC);
>>>
>>>          MachineInstr *CopyMI = prior(InsertLoc);
>>> +          CopyMI->setAsmPrinterFlag(AsmPrinter::ReloadReuse);
>>>          UpdateKills(*CopyMI, TRI, RegKills, KillOps);
>>>
>>>          // This invalidates DesignatedReg.
>>> @@ -2112,6 +2114,7 @@
>>>                // virtual or needing to clobber any values if it's
>>> physical).
>>>                NextMII = &MI;
>>>                --NextMII;  // backtrack to the copy.
>>> +                NextMII->setAsmPrinterFlag(AsmPrinter::ReloadReuse);
>>>                // Propagate the sub-register index over.
>>>                if (SubIdx) {
>>>                  DefMO = NextMII->findRegisterDefOperand(DestReg);
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>