[llvm-commits] [llvm] r87047 - in /llvm/trunk: include/llvm/Target/TargetInstrInfo.h lib/Target/X86/X86InstrInfo.cpp lib/Target/X86/X86InstrInfo.h

David Greene dag at cray.com
Thu Nov 12 16:40:59 PST 2009


On Thursday 12 November 2009 18:37, Bill Wendling wrote:

> > Because it's only being used for comments at the moment and those
> > don't
> > need to be 100% correct (though it would be nice).
>
> This makes no sense to me. What do you mean "comments"? What comments?

Asm comments.  The last bit still needs to be checked in (tomorrow).

> I'm not happy with the state of affairs. The build bots have been
> broken all day. Unless you can say that this patch fixes the *real*

That can't be just from me.  I only started checking in at 3pm.

> problem with the bootstrap, and not some "comment" that isn't
> "reliable" for correctness, then I'll be reverting all of your work
> today.

Yes, it fixes the "real" problem AFAICT.  Your testcase compiles.  I can't
see any other Darwin failures since I don't have access to a Darwin
box.

                                 -Dave



More information about the llvm-commits mailing list