[llvm-commits] [llvm] r86945 - /llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp

[Jim Grosbach]

Author: grosbach
Date: Wed Nov 11 21:28:35 2009
New Revision: 86945

URL: http://llvm.org/viewvc/llvm-project?rev=86945&view=rev
Log:
Revert 86857. It's causing consumer-typeset to fail, and there's a better way to do it forthcoming anyway.

Modified:
    llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp?rev=86945&r1=86944&r2=86945&view=diff

==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp Wed Nov 11 21:28:35 2009
@@ -294,11 +294,6 @@
   // sizes of each block, the location of all the water, and finding all of the
   // constant pool users.
   InitialFunctionScan(MF, CPEMIs);
-
-  bool MadeChange = false;
-  if (isThumb2)
-    MadeChange |= OptimizeThumb2JumpTables(MF);
-
   CPEMIs.clear();
 
   /// Remove dead constant pool entries.
@@ -306,6 +301,7 @@
 
   // Iteratively place constant pool entries and fix up branches until there
   // is no change.
+  bool MadeChange = false;
   unsigned NoCPIters = 0, NoBRIters = 0;
   while (true) {
     bool CPChange = false;
@@ -1480,6 +1476,7 @@
   }
 
   MadeChange |= OptimizeThumb2Branches(MF);
+  MadeChange |= OptimizeThumb2JumpTables(MF);
   return MadeChange;
 }
 
@@ -1725,8 +1722,8 @@
   JTBB->addSuccessor(NewBB);
 
   // Update internal data structures to account for the newly inserted MBB.
-  // Don't mark the new block as having water following it, as we want the
-  // blocks following the jump table to be as close together as possible.
+  // This is almost the same as UpdateForInsertedWaterBlock, except that
+  // the Water goes after OrigBB, not NewBB.
   MF.RenumberBlocks(NewBB);
 
   // Insert a size into BBSizes to align it properly with the (newly