[llvm-commits] [llvm] r85688 - in /llvm/trunk: include/llvm/Transforms/Utils/BasicBlockUtils.h lib/Transforms/Utils/BreakCriticalEdges.cpp

[Chris Lattner]

On Nov 1, 2009, at 1:59 AM, Duncan Sands wrote:

> Hi Chris,
>
>> +/// It is invalid to call this function on a critical edge that  
>> starts at an
>> +/// IndirectBrInst.  Splitting these edges will almost always  
>> create an invalid
>> +/// program because the addr of the new block won't be the one  
>> that is jumped
>
> addr -> address

Fixed in 85725

> Also, does this mean that every user of this needs to be updated to  
> check for
> and handle indirect branches?

Yes, I did that.  The only pieces remaining are some loop xforms that  
Dan is going to investigate.

-Chris