[llvm-commits] Added more 's' bit set encoding and "rs" register encoding bits

Bob Wilson bob.wilson at apple.com
Mon Oct 26 15:34:22 PDT 2009


As far as I can tell, the lack of predication for ADC/SBC is a  
temporary limitation in llvm.  Evan, can you confirm?

I've applied the rest of the patch for now, without the change to  
force the condition fields.  That should be done as a separate patch  
anyway, since it is unrelated to this change.

On Oct 26, 2009, at 11:48 AM, Johnny Chen wrote:

> Hi,
>
> For multiclass AI1_adde_sube_irs definition, I also added:
>
>    let Inst{31-28} = 0b1110;
>
> for the Sri, Srr, and Srs variants.  From the AsmString field of the  
> respective record definitions
> (take SBCSrs, for example):
>
> string AsmString = "sbcs $dst, $a, $b";
>
> it looks like this is the right thing to do.  Please remove the  
> three "set condition code to ALways"
> lines from the submitted patch if this is not correct.
>
> Thanks.
>
> <ARMInstrInfo.td.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list