[llvm-commits] [llvm] r81719 - in /llvm/trunk: unittests/Makefile unittests/TestMain.cpp utils/unittest/Makefile utils/unittest/UnitTestMain/ utils/unittest/UnitTestMain/Makefile utils/unittest/UnitTestMain/TestMain.cpp

[Julien Lerouge]

On Wed, Sep 30, 2009 at 02:59:29PM -0700, Julien Lerouge wrote:
> On Sun, Sep 27, 2009 at 02:20:39PM -0700, Chris Lattner wrote:
> > On Sep 18, 2009, at 9:11 AM, Julien Lerouge wrote:
> >>> +++ llvm/trunk/utils/unittest/UnitTestMain/Makefile Sun Sep 13 16:31:21 
> >>> 2009
> >>> @@ -16,9 +16,4 @@
> >>> CPP.Flags += -I$(LLVM_SRC_ROOT)/utils/unittest/googletest/include
> >>> CPP.Flags += -Wno-variadic-macros
> >>>
> >>
> >> -Wno-variadic-macros is not supported with older GCC, can we re-use the
> >> logic in googletest/Makefile ? patch attached.
> >
> > This patch seems reasonable to me, though an autoconf check for those flags 
> > would be even better (make builds go faster).
> >
> 
> This patch adds an autoconf check and removes another flag that was used
> in unittests/Makefile.unittest. I have kept the orignal names (NO_xxx).
> Should fix the build with older GCC.
> 
> Thanks,
> Julien

Is it ok to commit this thing ? It's blocking the build of LLVM on MingW
with gcc < 4

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090928/088200.html

Thanks,
Julien

-- 
Julien Lerouge
PGP Key Id: 0xB1964A62
PGP Fingerprint: 392D 4BAD DB8B CE7F 4E5F FA3C 62DB 4AA7 B196 4A62
PGP Public Key from: keyserver.pgp.com