[llvm-commits] Static Profile Patch

[Andrei Alvares]

Hello Andreas,
  Sorry for taking such a while to reply to you. I haven't noticed your
-mail before and I was busy with my master thesis.

On Tue, Oct 13, 2009 at 5:39 AM, Andreas Neustifter <astifter-llvm at gmx.at>wrote:

> Hi Andrei!
>
> Sorry, took me a while to get to this.
>
> The implementation looks good and solid, I haven't had time for an
> in-depth review, but from what I gather the Wu's algorithm is properly
> implemented.
>
>
Thanks. From the 9 heuristics, I'm having some problem with only three of
them. They are presenting low hit rates compared with Ball's probabilities.
The heuristics are: store heuristics (48%, mines vs. 55%, Ball's), call
heuristic (57% vs. 78%) and opcode heuristic (60% vs. 80%). I've looked into
opcode heuristic and haven't found any problem yet, but further
investigation is required. Call heuristic is doing very badly on the float
spec. So, if we want to make improvements, the best way is to target those
heuristics first.


> The patch does not build against revision 83533 (2009-10-08 09:01:46)
> with the build complaining about cyclic dependencies between
> libLLVMAnalysis.a and libLLVMipa.a. Any ideas about this?
>
>
You're right. I was aware of it, but I thought that it would be fixed once
the patch was inserted into the three. Unfortunately, that is not the case.

I've tracked the problem and discovered that I was using CallGraph within
StaticProfilePass. But since CallGraph is an IPA and StaticProfilePass is an
Analysis, it was getting a circular dependency. I just moved
StaticProfilePass to be an IPA. I've also fixed the patch to be applied in
the current tree. Here it follows the attachment: stprof-24.10.09.patch.


> Andi
>

  Thanks,
    Andrei
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091024/afe80f3b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stprof-24.10.09.patch
Type: text/x-patch
Size: 99891 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091024/afe80f3b/attachment.bin>