[llvm-commits] FW: [PATCH] Fix to pass options from Gold plugin to LTO codegen

[Nick Lewycky]

Viktor Kutuzov wrote:
> Hello everyone,
> 
> Please find the patch attached.
> This should fix the issue when gold plugin doesn't pass the  -plugin-opt options down to the LTO codegen.
> See the thread "[LLVMdev] getting gold plugin to work?" for more details.
> 
> This is the second try.
> It looks like the first one was bounced, not sure why.
> Sorry if anyone will get it twise.

Hi Viktor, this looks like the same patch I already reviewed here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20091019/089467.html

To reiterate:
"What's the difference between setCodeGenDebugOptions and
setCodeGenOption? It looks like they should be merged into one then
exposed by lto_codegen_set_option. And that would be even better if it
took an argc+argv pair, even if that's a little harder to construct from
the gold plugin, many option parsing packages work by removing the
options they recognize from argc+argv and leaving the rest in place."

Nick