[llvm-commits] [llvm-gcc-4.2] r84829 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Duncan Sands]

Hi Chris,

> The two fixes take a different approach (as far as I understand it).  
> The major difference is that I want the warning from instcombine when 
> you do this in C:
> 
> void foo() {.}
>  ... foo(4);  ...

gcc doesn't warn about this, even gcc-4.4, so why should llvm-gcc?  And if you
really want llvm-gcc to warn about it, why not add the logic for that to the
C frontend?

> but not when you do this in C++:
> 
> void foo(...) {.}
>  ... foo(4);  ...

> 
> My understanding is that Rafael's patch won't produce a warning in the 
> first case.

I don't remember, hopefully Rafael will comment.

Ciao,

Duncan.