[llvm-commits] [llvm] r84790 - /llvm/trunk/lib/VMCore/Metadata.cpp

[Benjamin Kramer]

Am 22.10.2009 um 01:22 schrieb Chris Lattner:

>
> On Oct 21, 2009, at 3:55 PM, Benjamin Kramer wrote:
>
>> Author: d0k
>> Date: Wed Oct 21 17:55:51 2009
>> New Revision: 84790
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=84790&view=rev
>> Log:
>> Simplify code. No intended functionality change.
>
> Thanks Benjamin!
>> +++ llvm/trunk/lib/VMCore/Metadata.cpp Wed Oct 21 17:55:51 2009
>> @@ -259,23 +259,17 @@
>>
>> /// isValidName - Return true if Name is a valid custom metadata  
>> handler name.
>> bool MetadataContext::isValidName(const StringRef MDName) {
>> -  const char *Name = MDName.data();
>> -  if (!Name)
>> +  if (MDName.empty())
>>    return false;
>>
>> -  if (!isalpha(*Name))
>> +  if (!isalpha(MDName[1]))
>
> I think this should be [0] not [1].
>
> -Chris

Thanks for noticing that stupid mistake. Fixed in 84797.