[llvm-commits] [llvm] r84786 - in /llvm/trunk: include/llvm/Metadata.h lib/VMCore/Metadata.cpp

[Devang Patel]

Author: dpatel
Date: Wed Oct 21 16:57:13 2009
New Revision: 84786

URL: http://llvm.org/viewvc/llvm-project?rev=84786&view=rev
Log:
Use StringRef.

Modified:
    llvm/trunk/include/llvm/Metadata.h
    llvm/trunk/lib/VMCore/Metadata.cpp

Modified: llvm/trunk/include/llvm/Metadata.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Metadata.h?rev=84786&r1=84785&r2=84786&view=diff

==============================================================================
--- llvm/trunk/include/llvm/Metadata.h (original)
+++ llvm/trunk/include/llvm/Metadata.h Wed Oct 21 16:57:13 2009
@@ -287,14 +287,14 @@
 public:
   /// registerMDKind - Register a new metadata kind and return its ID.
   /// A metadata kind can be registered only once. 
-  unsigned registerMDKind(const char *Name);
+  unsigned registerMDKind(const StringRef Name);
 
   /// getMDKind - Return metadata kind. If the requested metadata kind
   /// is not registered then return 0.
-  unsigned getMDKind(const char *Name);
+  unsigned getMDKind(const StringRef Name) const;
 
   /// isValidName - Return true if Name is a valid custom metadata handler name.
-  bool isValidName(const char *Name);
+  static bool isValidName(const StringRef Name);
 
   /// getMD - Get the metadata of given kind attached to an Instruction.
   /// If the metadata is not found then return 0.

Modified: llvm/trunk/lib/VMCore/Metadata.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/VMCore/Metadata.cpp?rev=84786&r1=84785&r2=84786&view=diff

==============================================================================
--- llvm/trunk/lib/VMCore/Metadata.cpp (original)
+++ llvm/trunk/lib/VMCore/Metadata.cpp Wed Oct 21 16:57:13 2009
@@ -250,7 +250,7 @@
 
 /// registerMDKind - Register a new metadata kind and return its ID.
 /// A metadata kind can be registered only once. 
-unsigned MetadataContext::registerMDKind(const char *Name) {
+unsigned MetadataContext::registerMDKind(const StringRef Name) {
   assert(isValidName(Name) && "Invalid custome metadata name!");
   unsigned Count = MDHandlerNames.size();
   assert(MDHandlerNames.count(Name) == 0 && "Already registered MDKind!");
@@ -258,7 +258,8 @@
 }
 
 /// isValidName - Return true if Name is a valid custom metadata handler name.
-bool MetadataContext::isValidName(const char *Name) {
+bool MetadataContext::isValidName(const StringRef MDName) {
+  const char *Name = MDName.data();
   if (!Name)
     return false;
 
@@ -280,8 +281,8 @@
 
 /// getMDKind - Return metadata kind. If the requested metadata kind
 /// is not registered then return 0.
-unsigned MetadataContext::getMDKind(const char *Name) {
-  StringMap<unsigned>::iterator I = MDHandlerNames.find(Name);
+unsigned MetadataContext::getMDKind(const StringRef Name) const {
+  StringMap<unsigned>::const_iterator I = MDHandlerNames.find(Name);
   if (I == MDHandlerNames.end()) {
     assert(isValidName(Name) && "Invalid custome metadata name!");
     return 0;