[llvm-commits] [PATCH] Introduce -dbg-quality test

[Devang Patel]

Hi

2009/10/21 Török Edwin <edwintorok at gmail.com>:
> Hi Devang,
>
> I've written the -dbg-quality pass (attached), and the
> TEST.dbgquality.Makefile that tests the optimized (-std-compile-opts)
> bitcode file.

This is great. Could you explain how you qualify debug info to get the
following score ?

> Should I also add a -std-link-opts tests?

Yes.

> I think some
> passes (such as -ipsccp) are only run there?
> I've attached the results, the maximum score is 10000 (meaning all
> non-alloca/non-dbgintrinsic instructions have debug info).
> We have 79 tests at 10000 quality, the rest are between 5331 - 9999.
>
> I've also found a bug: static constructors/destructors have out-of-file
> line numbers often (PR5270). I've added a hack in -dbg-quality for now
> that ignores those functions (denoted by a FIXME).

I'll take a look at this PR.

> OK to commit, or should I wait till PR5270 is fixed so I can drop the
> ugly hack?

I do not think Analysis is a good place for this and DebugInfo as
well. I think, DebugInfo is in Analysis, because we do not want it in
VMCore. IMO, debug info related code should be in lib/Support. Chris,
what do you think ?

Thanks for working on this!
-
Devang