[llvm-commits] [PATCH] Sanitize the JITResolver stub/callsite<->function maps

[Evan Cheng]

It looks very reasonable to me.

Evan

On Oct 19, 2009, at 10:45 AM, Jeffrey Yasskin wrote:

> Evan, Chris says you're one of the right people to take a look at
> this. Could you?
>
> Thanks,
> Jeffrey
>
> On Wed, Oct 14, 2009 at 4:28 PM,  <jyasskin at gmail.com> wrote:
>> Reviewers: ,
>>
>> Message:
>> Patch at http://codereview.appspot.com/download/issue130080_1.diff
>>
>> This passes check-lit.
>>
>> Description:
>> The JITResolver maps Functions to their canonical stubs and all
>> callsites for lazily-compiled functions to their target Functions. To
>> make Function destruction work, I'm going to need to remove all
>> callsites on destruction, so this patch also adds the reverse mapping
>> for that.
>>
>> There was an incorrect assumption in here that the only stub for a
>> function would be the one caused by needing to lazily compile it,  
>> while
>> x86-64 far calls and dlsym-stubs could also cause such stubs, but I
>> didn't look for a test case that the assumption broke.
>>
>> This also adds DenseMapInfo<AssertingVH> so I can use DenseMaps  
>> instead
>> of std::maps.
>>
>> Please review this at http://codereview.appspot.com/130080
>>
>> Affected files:
>>   M include/llvm/Support/ValueHandle.h
>>   M lib/ExecutionEngine/JIT/JITEmitter.cpp
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>