[llvm-commits] PATCH: Additional DebugFactory methods

[Talin]

Here's an updated version of the patch which uses StringRef as requested.
Also, I have changed the method names to avoid the ambiguity problems
encountered in the last patch. The new methods end with "Ex" which can stand
either for "Expression" or "Extension" depending on your preference. :)

On Sat, Oct 17, 2009 at 9:32 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Oct 5, 2009, at 10:48 PM, Talin wrote:
>
>  The attached patch adds some additional convenience methods to
>> DebugFactory. Specifically, methods that take a uint64 for size, alignment
>> or offset, can now also take a Constant *. This is very useful for
>> target-independent frontends which can use things like
>> ConstantExpr::getSizeof(). I've been using this for about a week in my own
>> code and it seems to work fine,
>>
>
> Hi Talin,
>
> Sorry for the delay, still getting caught up.  Please change this to use
> StringRef like the current DebugInfo.h methods do.
>
> Devang, can you review this in more detail?
>
> -Chris
>
>


-- 
-- Talin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091018/3dbd8077/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debug_constants.patch
Type: application/octet-stream
Size: 7760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091018/3dbd8077/attachment.obj>