[llvm-commits] [PATCH] Fix lit.py for gtest "typed tests"

Daniel Dunbar daniel at zuster.org
Sat Oct 17 16:18:59 PDT 2009


On Sat, Oct 17, 2009 at 11:31 AM, Jeffrey Yasskin <jyasskin at google.com> wrote:
> GTest has a kind of test whose names look like
> "ValueMapTest/0.Iteration":
> http://code.google.com/p/googletest/wiki/GoogleTestAdvancedGuide#Typed_Tests.
> This broke lit.py, which os.path.join()ed the test name onto the
> test's path and assumed that it could recover the name as the second
> result of os.path.split. This patch shifts path components from the
> testPath to the testName until the testPath exists.

LGTM, although I can't tell if its possible to have multiple slashes
in the test name from my cursory reading of the doc. If it isn't,
maybe better to just have an if instead of a while?

 - Daniel

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>



More information about the llvm-commits mailing list