[llvm-commits] [llvm] r84106 - in /llvm/trunk: docs/ExceptionHandling.html include/llvm/IntrinsicInst.h include/llvm/Intrinsics.td lib/CodeGen/IntrinsicLowering.cpp lib/CodeGen/SelectionDAG/FastISel.cpp lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp lib/CodeGen/SjLjEHPrepare.cpp lib/VMCore/AutoUpgrade.cpp

Chris Lattner clattner at apple.com
Fri Oct 16 23:59:23 PDT 2009


On Oct 14, 2009, at 9:11 AM, Duncan Sands wrote:

> Author: baldrick
> Date: Wed Oct 14 11:11:37 2009
> New Revision: 84106
>
> URL: http://llvm.org/viewvc/llvm-project?rev=84106&view=rev
> Log:
> I don't see any point in having both eh.selector.i32 and  
> eh.selector.i64,
> so get rid of eh.selector.i64 and rename eh.selector.i32 to  
> eh.selector.
> Likewise for eh.typeid.for.  This aligns us with gcc, which always  
> uses a
> 32 bit value for the selector on all platforms.  My understanding is  
> that
> the register allocator used to assert if the selector intrinsic size  
> didn't
> match the pointer size, and this was the reason for introducing the  
> two
> variants.  However my testing shows that this is no longer the case (I
> fixed some bugs in selector lowering yesterday, and some more today  
> in the
> fastisel path; these might have caused the original problems).

Nice, thank you for adding the autoupgrade code.

-Chris




More information about the llvm-commits mailing list