[llvm-commits] [PATCH] Make ExecutionEngine automatically remove global mappings on GlobalValue destruction

Evan Cheng evan.cheng at apple.com
Tue Oct 13 02:01:15 PDT 2009


Looks good to me. I'd preferred if "state" can be renamed to something  
like EEState though.

Evan

On Oct 12, 2009, at 5:43 PM, jyasskin at gmail.com wrote:

> Reviewers: ,
>
> Message:
> http://codereview.appspot.com/download/issue129074_5.diff
>
> This doesn't make the ExecutionEngine do everything perfectly on
> GlobalValue destruction (stubs still crash and machine code still
> leaks), but it's progress.
>
>
>
> Please review this at http://codereview.appspot.com/129074
>
> Affected files:
>   M include/llvm/ExecutionEngine/ExecutionEngine.h
>   M lib/ExecutionEngine/ExecutionEngine.cpp
>   M unittests/ExecutionEngine/ExecutionEngineTest.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list