[llvm-commits] patch: memory use markers

Dan Gohman gohman at apple.com
Mon Oct 12 09:31:43 PDT 2009


On Oct 11, 2009, at 3:25 PM, Nick Lewycky wrote:

> This patch adds memory use markers as described in http://nondot.org/sabre/LLVMNotes/MemoryUseMarkers.txt 
>  . The bulk of the patch makes it possible to have intrinsics which  
> return {}.

Hi Nick,

The use of {} here is clever, but I don't think it's correct. Since {}  
has
no members, the set of values has exactly one element, which means
that all values of type {} can be assumed to be equivalent. Please use
something like opaque* instead.

With @llvm.invariant.end being marked readonly and nounwind, and having
a void return type, it would seem to be trivially dead everywhere.  
Should
the readonly be removed?

Dan




More information about the llvm-commits mailing list