[llvm-commits] [llvm-gcc-4.2] r83329 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Eric Christopher]

On Oct 5, 2009, at 3:22 PM, Chris Lattner wrote:

>
> On Oct 5, 2009, at 3:16 PM, Eric Christopher wrote:
>
>> Author: echristo
>> Date: Mon Oct  5 17:16:12 2009
>> New Revision: 83329
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=83329&view=rev
>> Log:
>> Use FUNCTION_BOUNDARY for default function alignment. Use  
>> BITS_PER_UNIT
>> instead of 8 for computing alignment size - this is almost always
>> 8 anyhow.
>
> The last time I did this, Duncan pointed out that it is actually  
> wrong.  LLVM does alignment in bytes, so if BITS_PER_UNIT is (e.g.)  
> 32, then we'd get the wrong results.

Hmm... I guess so.  If this ever actually came up we'd probably see  
problems all over the place anyhow. I'll revert that part :)

-eric