[llvm-commits] [zorg] r82960 - /zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py

[Daniel Dunbar]

Author: ddunbar
Date: Sun Sep 27 20:49:54 2009
New Revision: 82960

URL: http://llvm.org/viewvc/llvm-project?rev=82960&view=rev
Log:
Unbreak the InformativeMailNotifier comparison function.

Modified:
    zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py

Modified: zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py?rev=82960&r1=82959&r2=82960&view=diff

==============================================================================
--- zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py (original)
+++ zorg/trunk/zorg/buildbot/util/InformativeMailNotifier.py Sun Sep 27 20:49:54 2009
@@ -1,11 +1,14 @@
-import buildbot.util
+from buildbot import util, interfaces
+from zope.interface import implements
 from buildbot.status import builder, mail
 
-class InformativeMailNotifier(mail.MailNotifier, buildbot.util.ComparableMixin):
+class InformativeMailNotifier(mail.MailNotifier):
     """MailNotifier subclass which provides additional information about the
     build failure inside the email."""
 
-    compare_attrs = ["num_lines", "only_failure_logs"]
+    implements(interfaces.IEmailSender)
+    compare_attrs = (mail.MailNotifier.compare_attrs +
+                     ["num_lines", "only_failure_logs"])
 
     # FIXME: The customMessage interface is fairly inefficient, switch to
     # something new when it becomes available.
@@ -19,6 +22,10 @@
         self.only_failure_logs = only_failure_logs
 
     def customMessage(self, attrs):
+        # FIXME: It would be nice to find a way to communicate with
+        # the lookup mechanism so that we could note any committers
+        # who we weren't able to send email to.
+
         # Get the standard message.
         data = mail.message(attrs)[0]