[llvm-commits] [llvm] r82685 - in /llvm/trunk: CMakeLists.txt test/Scripts/count test/Scripts/not utils/Makefile utils/count/ utils/count/CMakeLists.txt utils/count/Makefile utils/count/count.c utils/not/ utils/not/CMakeLists.txt utils/not/Makefi

[Daniel Dunbar]

2009/9/24 Török Edwin <edwintorok at gmail.com>:
> On 2009-09-24 09:23, Daniel Dunbar wrote:
>> Author: ddunbar
>> Date: Thu Sep 24 01:23:57 2009
>> New Revision: 82685
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=82685&view=rev
>> Log:
>> Add count/not tools as executables.
>>  - Apparently, I'm willing to do incredibly stupid things in the name of portability.
>>
>
> How many tests still use count/not?

Dunno. A hell of a lot would be my first and only guess?
--
ddunbar at lordcrumb:llvm (master)$ find test | xargs grep '| count' | wc -l
    2048
--

> Can't they be converted to CHECK: ?

A lot can, probably, but this is a lot of work. Even my auto
FileCheckifier (which is currently vaporware, of course) might not
eventually do this. It is probably incorrect and pointless to turn:
--
// RUN: foo | grep bar | count 232
--
into:
--
// RUN: foo | FileCheck ...
// CHECK: bar
// CHECK: bar
// CHECK: bar
// CHECK: bar
...
// CHECK: bar
--
when what really should happen is the test should be more meaningful.

Someone else is free to make this their mission in life, though. :)

 - Daniel