[llvm-commits] [llvm] r82040 - /llvm/trunk/lib/CodeGen/MachineModuleInfoImpls.cpp

[Nick Lewycky]

Benjamin Kramer wrote:
> Author: d0k
> Date: Wed Sep 16 06:43:12 2009
> New Revision: 82040
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=82040&view=rev
> Log:
> Don't sort the vector when it is empty. This should fix some expensive checking
> failures.

qsort? Why are we using qsort?

> Modified:
>     llvm/trunk/lib/CodeGen/MachineModuleInfoImpls.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/MachineModuleInfoImpls.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineModuleInfoImpls.cpp?rev=82040&r1=82039&r2=82040&view=diff
> 
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/MachineModuleInfoImpls.cpp (original)
> +++ llvm/trunk/lib/CodeGen/MachineModuleInfoImpls.cpp Wed Sep 16 06:43:12 2009
> @@ -38,7 +38,8 @@
>  MachineModuleInfoMachO::GetSortedStubs(const DenseMap<const MCSymbol*, 
>                                                        const MCSymbol*> &Map) {
>    MachineModuleInfoMachO::SymbolListTy List(Map.begin(), Map.end());
> -  qsort(&List[0], List.size(), sizeof(List[0]), SortSymbolPair);
> +  if (!List.empty())
> +    qsort(&List[0], List.size(), sizeof(List[0]), SortSymbolPair);
>    return List;
>  }
>  
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>