[llvm-commits] [PATCH] extend SelectionDAGBuild to treat malloc calls the same as MallocInst (patch #4)

[Victor Hernandez]

On Sep 15, 2009, at 2:39 PM, Eli Friedman wrote:

> On Tue, Sep 15, 2009 at 1:44 PM, Victor Hernandez <vhernandez at apple.com 
> > wrote:
>> SelectionDAGBuild is the only pass in CodeGen that handles MallocInst
>> specially.  This patch extends that code to handle malloc calls also.
>
> This part is both wrong and not necessary.
>
Eli, Thanks for the feedback.

I was under the impression that visitMalloc() did something malloc- 
specific that was needed even when using a malloc call and bitcast  
instead of MallocInst.  Looking at the code, I see that visitCall()  
and visitBitCast() do all that is necessary for SelectionDAG  
translating.

Do you have any thoughts on the 3 other patches I sent out?

thanks,
Victor