[llvm-commits] [llvm] r81967 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h lib/CodeGen/AsmPrinter/AsmPrinter.cpp lib/CodeGen/AsmPrinter/DwarfException.cpp

[Chris Lattner]

Author: lattner
Date: Tue Sep 15 19:17:39 2009
New Revision: 81967

URL: http://llvm.org/viewvc/llvm-project?rev=81967&view=rev
Log:
Eliminate AsmPrinter::EmitExternalGlobal, inlining its (now)
one implementation into its one caller.  This eliminates a totally
awesome and gratuitous hack where we casted a Function* to 
GlobalVariable*.

Modified:
    llvm/trunk/include/llvm/CodeGen/AsmPrinter.h
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfException.cpp

Modified: llvm/trunk/include/llvm/CodeGen/AsmPrinter.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/AsmPrinter.h?rev=81967&r1=81966&r2=81967&view=diff

==============================================================================
--- llvm/trunk/include/llvm/CodeGen/AsmPrinter.h (original)
+++ llvm/trunk/include/llvm/CodeGen/AsmPrinter.h Tue Sep 15 19:17:39 2009
@@ -159,10 +159,6 @@
     ///
     bool isVerbose() const { return VerboseAsm; }
 
-    /// EmitExternalGlobal - Emit the external reference to a global variable.
-    /// Should be overridden if an indirect reference should be used.
-    virtual void EmitExternalGlobal(const GlobalVariable *GV);
-
     /// getCurrentFunctionEHName - Called to return the CurrentFnEHName.
     /// 
     std::string getCurrentFunctionEHName(const MachineFunction *MF) const;

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=81967&r1=81966&r2=81967&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Tue Sep 15 19:17:39 2009
@@ -509,13 +509,6 @@
     }
 }
 
-/// EmitExternalGlobal - Emit the external reference to a global variable.
-/// Should be overridden if an indirect reference should be used.
-void AsmPrinter::EmitExternalGlobal(const GlobalVariable *GV) {
-  O << Mang->getMangledName(GV);
-}
-
-
 
 //===----------------------------------------------------------------------===//
 /// LEB 128 number encoding.

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfException.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfException.cpp?rev=81967&r1=81966&r2=81967&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfException.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfException.cpp Tue Sep 15 19:17:39 2009
@@ -163,7 +163,7 @@
     O << MAI->getData32bitsDirective();
     
     O << MAI->getPersonalityPrefix();
-    Asm->EmitExternalGlobal((const GlobalVariable *)(Personality));
+    O << Asm->Mang->getMangledName(Personality);
     O << MAI->getPersonalitySuffix();
     
     if (strcmp(MAI->getPersonalitySuffix(), "+4 at GOTPCREL"))