[llvm-commits] [llvm] r80710 - in /llvm/trunk/lib: CodeGen/AsmPrinter/DwarfException.cpp Target/ARM/AsmPrinter/ARMAsmPrinter.cpp

Daniel Dunbar daniel at zuster.org
Tue Sep 15 16:43:26 PDT 2009


Done in r81912.

 - Daniel

On Thu, Sep 3, 2009 at 9:47 AM, Chris Lattner <clattner at apple.com> wrote:
>
> On Sep 3, 2009, at 12:46 AM, Daniel Dunbar wrote:
>
>> On Wed, Sep 2, 2009 at 10:24 PM, Chris Lattner<clattner at apple.com> wrote:
>>>
>>> On Sep 2, 2009, at 10:01 PM, Daniel Dunbar wrote:
>>>>
>>>> On Wed, Sep 2, 2009 at 9:59 PM, Daniel Dunbar<daniel at zuster.org> wrote:
>>>>>
>>>>> I'm happy to work on fixing this if someone has a good plan.
>>>>> raw_ostream doesn't really seem to need its 64 byte buffer, for
>>>>> example. When I first implemented
>>>>
>>>> ... the magic I-ownz-your-buffer ..., that is.
>>>
>>> Ah, ok, bumping it up to 64 with a comment about this seems reasonable.
>>
>> That seems burdensome for all callers, we should probably fix the API.
>> What if we dropped the raw_ostream required buffer size to 4, since I
>> think thats actually all that is required?
>
> Yes, that would be a much better solution,
>
> -chris
>



More information about the llvm-commits mailing list