[llvm-commits] [llvm] r81716 - /llvm/trunk/lib/VMCore/Verifier.cpp

[Nick Lewycky]

Chris Lattner wrote:
> 
> On Sep 13, 2009, at 2:07 PM, Nick Lewycky wrote:
> 
>> Author: nicholas
>> Date: Sun Sep 13 16:07:59 2009
>> New Revision: 81716
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=81716&view=rev
>> Log:
>> Storing a set of PATypeHolders is a bad idea because their sort order 
>> will
>> change as types are refined. Remove abstract types from CheckedTypes 
>> when they
>> we're informed that they have been refined. The only way types get 
>> refined in
>> the verifier is when later function passes start optimizing. Fixes 
>> PR4970.
> 
> Thanks Nicholas,
> 
> However, instead of making the Verifier itself an AbstractTypeUser, 
> please make a new class that contains the set and is an 
> AbstractTypeUser.  The Verifier can then have that object through 
> containment.

Done!