[llvm-commits] [llvm] r81328 - in /llvm/trunk/lib/System: Unix/Program.inc Win32/Program.inc

[Mikhail Glushenkov]

Author: foldr
Date: Wed Sep  9 04:51:47 2009
New Revision: 81328

URL: http://llvm.org/viewvc/llvm-project?rev=81328&view=rev
Log:
Check that the 'kill' call succeeded.

Thanks to Duncan Sands for spotting this.

Modified:
    llvm/trunk/lib/System/Unix/Program.inc
    llvm/trunk/lib/System/Win32/Program.inc

Modified: llvm/trunk/lib/System/Unix/Program.inc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Unix/Program.inc?rev=81328&r1=81327&r2=81328&view=diff

==============================================================================
--- llvm/trunk/lib/System/Unix/Program.inc (original)
+++ llvm/trunk/lib/System/Unix/Program.inc Wed Sep  9 04:51:47 2009
@@ -298,7 +298,13 @@
 
   uint64_t pid64 = reinterpret_cast<uint64_t>(Data_);
   pid_t pid = static_cast<pid_t>(pid64);
-  return (kill(pid, SIGKILL) == 0);
+
+  if (kill(pid, SIGKILL) != 0) {
+    MakeErrMsg(ErrMsg, "The process couldn't be killed!");
+    return true;
+  }
+
+  return false;
 }
 
 bool Program::ChangeStdinToBinary(){

Modified: llvm/trunk/lib/System/Win32/Program.inc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/System/Win32/Program.inc?rev=81328&r1=81327&r2=81328&view=diff

==============================================================================
--- llvm/trunk/lib/System/Win32/Program.inc (original)
+++ llvm/trunk/lib/System/Win32/Program.inc Wed Sep  9 04:51:47 2009
@@ -347,7 +347,12 @@
   }
 
   HANDLE hProcess = reinterpret_cast<HANDLE>(Data_);
-  return TerminateProcess(hProcess, 1);
+  if (TerminateProcess(hProcess, 1) == 0) {
+    MakeErrMsg(ErrMsg, "The process couldn't be killed!");
+    return true;
+  }
+
+  return false;
 }
 
 bool Program::ChangeStdinToBinary(){