[llvm-commits] [PATCH] Make TypeBuilder's result depend on the LLVMContext it's passed

jyasskin at gmail.com jyasskin at gmail.com
Tue Sep 8 17:52:34 PDT 2009


Reviewers: resistor_mac.com,

Message:
The patch is at
http://codereview.appspot.com/download/issue115073_1.diff.  I'm going to
ask Tanya to merge this into 2.6 when it's committed, since it makes
multi-Context programs break in hard-to-diagnose ways.

Description:
Make TypeBuilder's result depend on the LLVMContext it's passed.
TypeBuilder was using a local static variable to cache its result. This
made it ignore changes in its LLVMContext argument and always return a
type constructed from the argument to the first call.

Please review this at http://codereview.appspot.com/115073

Affected files:
   M     include/llvm/Support/TypeBuilder.h
   M     unittests/Support/TypeBuilderTest.cpp





More information about the llvm-commits mailing list