[llvm-commits] [llvm] r81126 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp

Duncan Sands baldrick at free.fr
Sun Sep 6 22:10:00 PDT 2009


Hi Evan,

> This seems wrong. Perhaps the switch statement should be something like 
> this?
> 
>   case X86II::MO_NO_FLAG:    // No flag.
>     break;
>   case X86II::MO_PIC_BASE_OFFSET:
>   case X86II::MO_DARWIN_NONLAZY_PIC_BASE:
>   case X86II::MO_DARWIN_HIDDEN_NONLAZY_PIC_BASE:
>     // Subtract the pic base.
>     NegatedSymbol = GetPICBaseSymbol();
>     break;

the value of NegatedSymbol was not being used.

Ciao,

Duncan.



More information about the llvm-commits mailing list